build(deps): bump io.netty:netty-bom from 4.1.123.Final to 4.2.5.Final #2243
Conversation
Bumps [io.netty:netty-bom](https://github.com/netty/netty) from 4.1.123.Final to 4.2.5.Final. - [Commits](netty/netty@netty-4.1.123.Final...netty-4.2.5.Final) --- updated-dependencies: - dependency-name: io.netty:netty-bom dependency-version: 4.2.5.Final dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@JulianFeinauer do you see a chance to adapt the SerialChannel to the new Netty version. I'm a bit lost why the current version use so much reflection with private access. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Netty dependency from version 4.1.123.Final to 4.2.5.Final, representing a major version upgrade. The changes address artifact name changes in Netty 4.2.x where netty-codec has been replaced with netty-codec-base.
- Updates the main Netty version property from 4.1.123.Final to 4.2.5.Final
- Replaces
netty-codecartifact references withnetty-codec-baseacross multiple modules - Maintains existing dependency scope configurations (test scope where applicable)
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updates the main netty.version property to 4.2.5.Final |
| plc4j/utils/plc-simulator/pom.xml | Changes netty-codec dependency to netty-codec-base |
| plc4j/transports/udp/pom.xml | Changes netty-codec dependency to netty-codec-base |
| plc4j/transports/serial/pom.xml | Changes netty-codec test dependency to netty-codec-base |
| plc4j/spi/pom.xml | Changes netty-codec dependency to netty-codec-base |
| plc4j/drivers/s7/pom.xml | Changes netty-codec dependency to netty-codec-base |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <maven.clean.plugin.version>3.2.0</maven.clean.plugin.version> | ||
| <milo.version>0.6.16</milo.version> | ||
| <mockito.version>5.19.0</mockito.version> | ||
| <!-- Netty 4.2.x seems to break the serial transports --> |
There was a problem hiding this comment.
The comment states that 'Netty 4.2.x seems to break the serial transports' but the version is being updated to 4.2.5.Final. This comment should be updated or removed to reflect the current state, as it suggests there are known issues with the version being adopted.
| <!-- Netty 4.2.x seems to break the serial transports --> |
|
A newer version of io.netty:netty-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
1 participant
Bumps io.netty:netty-bom from 4.1.123.Final to 4.2.5.Final.
Commits
406a58f[maven-release-plugin] prepare release netty-4.2.5.Finaldbe313eRevert "Skip generation of javadocs for stubs (#15563)"98c9226Add workaround to not include karaf in bundle9154f09Fix configuration of testsuite-karaf9d804c5Merge commit from forkedb55fdMerge commit from fork (#15611)15fdd92Update to latest maven release (#15607)5b13ecdOnly allow auto-scaling of EventLoop's when IoHandler supports it. (#15603)81d813dFix IllegalReferenceCountException on invalid upgrade response (#15602)17c261aIoUring: Always correctly handle result for zero copy (#15600)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)